diagnostics_channel: add diagnostics channels for web locks#62123
Open
IlyasShabi wants to merge 2 commits intonodejs:mainfrom
Open
diagnostics_channel: add diagnostics channels for web locks#62123IlyasShabi wants to merge 2 commits intonodejs:mainfrom
IlyasShabi wants to merge 2 commits intonodejs:mainfrom
Conversation
IlyasShabi
force-pushed
the
ishabi/web-lock-dc
branch
from
c92cc75 to
8ce0c9b
Compare
IlyasShabi
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62123 +/- ##
==========================================
+ Coverage 88.84% 89.65% +0.81%
==========================================
Files 674 676 +2
Lines 204957 206604 +1647
Branches 39309 39554 +245
==========================================
+ Hits 182087 185232 +3145
+ Misses 15088 13502 -1586
- Partials 7782 7870 +88
🚀 New features to boost your workflow:
|
legendecas
added
the
diagnostics_channel
legendecas
reviewed
Mar 6, 2026
Qard
approved these changes
Mar 6, 2026
legendecas
reviewed
Mar 10, 2026
legendecas
approved these changes
Mar 10, 2026
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
IlyasShabi
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds diagnostics channels support for
locks.request()giving visibility into the lock request lifecycle.Four channels are emitted:
locks.request.startwhen a request beginslocks.request.grantwhen the lock is grantedlocks.request.misswhen the lock is not immediately availablelocks.request.endwhen the request finishes